STITCH-2546 Generate error if user ID is passed to destructive active user functions #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. I would debate passing a more descriptive error, but if you think UnexpectedArguments is enough then sounds good to me |
tkaye407
reviewed
Feb 28, 2019
Contributor
tkaye407
left a comment
tkaye407
left a comment
There was a problem hiding this comment.
LGTM (meant to leave the previous comment as my review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fear not the large number of additions and deletions, for they are only changes to
package-lock.json. I drive-by patched some (but not all) local dev environment npm dependency vulns withnpm audit fix.