Feature/mn 175/factorize monitor code #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

deepakglobant merged 6 commits into main from feature/MN-175/factorize-monitor-code

Feb 13, 2023

Contributor

deepakglobant commented Feb 3, 2023

Technical description

Create monitoring context to share functions and sentry config across the applications.
Initialise monitoring through context.
No need to pass config for sentry in each an every places.
Created errorMessage and measureMonitoring functionality.
Added custom hooks (useMonitoring) that will provide all the monitoring functions to use in each an every packages.

This Pull Request template has been written and generated by Monk JS repository.

deepakglobant added 3 commits

February 2, 2023 15:22


          feat: factorize monitoring code (MN-175)

605e0d4


          Merge branch 'main' of https://github.com/monkvision/monkjs into feat…

293680e

…ure/MN-176/factorize-monitor-code


          fix: merge with main branch

71736ea

deepakglobant requested review from rohitsharma120582 and souyahia-monk

February 3, 2023 07:04

rohitsharma120582 approved these changes

View reviewed changes

Contributor

rohitsharma120582 left a comment

LGTM!

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/types.ts Outdated Show resolved Hide resolved

deepakglobant force-pushed the feature/MN-175/factorize-monitor-code branch 2 times, most recently from eabafe6 to f98fe5e Compare

February 13, 2023 09:04

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/types.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/types.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/types.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/types.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/types.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/types.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

deepakglobant force-pushed the feature/MN-175/factorize-monitor-code branch from f98fe5e to 8b409c1 Compare

February 13, 2023 11:54

deepakglobant requested review from rohitsharma120582 and souyahia-monk

February 13, 2023 11:58

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/index.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/types.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/types.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/types.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/corejs/src/monitoring/types.ts Outdated Show resolved Hide resolved

deepakglobant force-pushed the feature/MN-175/factorize-monitor-code branch from 8b409c1 to 401516a Compare

February 13, 2023 14:44


          feat: set user in Sentry and added custom measurement

917d572

deepakglobant force-pushed the feature/MN-175/factorize-monitor-code branch from 401516a to 917d572 Compare

February 13, 2023 14:52

souyahia-monk approved these changes

View reviewed changes

deepakglobant merged commit dcc9690 into main

deepakglobant deleted the feature/MN-175/factorize-monitor-code branch

February 13, 2023 15:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet