This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Update csproj ToolsVersion to 4.0 #132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@Therzok, I think this is something that can be merged safely too. |
Contributor
|
This could break users still targeting .NET 3.5 on platforms which still provide it. |
|
build |
Contributor
|
@antoniusriha sorry to come so late to review this. The commit message should be expanded to contain the explanation that you have in the PR. Also, it's not entirely clear what "because 3.5 is not available any more on newer mono versions" means. What's the consequence of not being available? A build failure? The projects don't load in MonoDevelop? A MSBuild-only build failure? Would be great to explain this also in the commit message, and then I guess we can merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the ToolsVersion in the csproj files from 3.5 to 4.0 because 3.5 is not available any more on newer mono versions.