Adding CI build action (and fix usage of deprecated SPI APIs) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the pull request. I plan to work on improving this library later this year. I will address the compatibility issues at this moment. I will most likely change the SPI code to use the SPISettings. |
Collaborator
|
I ended up fixing the compatibility issue tonight. Now the code is compatible with all AVR, SAMD, mbed and ESP32 paltforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository was flagged during semi-automatic review for using any of the SPI APIs
setBitOrder,setDataMode,setClockDivider. Unfortunately those SPI APIs are only supported within ArduinoCore-avr and deprecated everywhere else.This is problematic because the
library.propertiesof this library indicates that any architecture is supported (architectures=*) as it raises expectations by the user that simply can not be fulfilled when using this library on any platform that does not support those SPI APIs.By donating this PR I'm hoping to start a conversation of either limiting the list of supported architectures to avr
or to adapt the code to use the SPISettings API supported in all cores.