Skip to content

Conversation

@andrewnicols
Copy link
Member

No description provided.

@andrewnicols andrewnicols self-assigned this Jun 10, 2024
@andrewnicols andrewnicols requested a review from sarjona June 10, 2024 12:43
@netlify
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 89b190a
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6666f4f14fe71900088d740c
😎 Deploy Preview https://deploy-preview-1042--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewnicols andrewnicols enabled auto-merge June 10, 2024 12:43
@github-actions
Copy link
Contributor

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 23 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 60 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 79 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 78 🟢 95 🟢 100 🟢 100 🟢 100 Report

Copy link
Collaborator

@timhunt timhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andrew. Looks good to me.

@andrewnicols andrewnicols added this pull request to the merge queue Jun 10, 2024
Merged via the queue into moodle:main with commit 6bd8146 Jun 10, 2024
@andrewnicols andrewnicols deleted the devmeeting-202405 branch June 10, 2024 13:53
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrewnicols!
I left a couple of comments but I've just seen you just merged it... Feel free to create a separate issue to fix them ;-)

## Agenda

1. Moodle Developer Experience (DX) update
1. [Moodle Developer Experience (DX) update](./_files/2024-03-Mikel-presentation.pdf)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. [Moodle Developer Experience (DX) update](./_files/2024-03-Mikel-presentation.pdf)
1. [Moodle Developer Experience (DX) update](./_files/2024-05-DX-presentation.pdf)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should point to the uploaded file, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from updating the presentation link, shouldn't the May meeting be listed in the general/community/meetings page too?

@timhunt
Copy link
Collaborator

timhunt commented Jun 10, 2024

Sorry, @sarjona. Mid-air collision.

@sarjona
Copy link
Member

sarjona commented Jun 10, 2024

No need to apologise, @timhunt!
They are easy to fix in a separate issue ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants