Validation error for using `global $PAGE` in block classes

[eduardokraus]

I created a class called block_type, and when running the code checker, I received the following error message:

global $PAGE cannot be used in block classes. Use $this->page.

Steps to reproduce:

1. Create a block class (e.g., block_type).
2. Try using global $PAGE within the class.
3. Run the code checker.

Expected behavior:

The code checker should allow the use of global $PAGE in appropriate contexts or provide a clearer message on how to adjust the code.

Current behavior:

The checker throws an error suggesting the use of $this->page without adequately explaining the situations where this should be applied.

Environment:

• Moodle version: 4.3
• Local Code Checker version: 2024070500

Possible solution:

It would be helpful to review the checker's logic to recognize the context where global $PAGE might be necessary or to better document when $this->page should be used.

Thank you!

[timhunt]

Yes, you should use $this->page in the block class. And the message tells you this. So, I don't understand what you are asking for.