phpdoc crashes with invalid component error

[tim1mw]

Using v4.5.6 running locally, I get the following error running phpdoc

Default exception handler: Coding error detected, it must be fixed by a programmer: Invalid component specified in renderer request Debug: local_moodlecheck
Error code: codingerror

• line 197 of /lib/outputfactories.php: coding_exception thrown
• line 389 of /lib/outputfactories.php: call to renderer_factory_base->standard_renderer_classnames()
• line 2427 of /lib/outputlib.php: call to theme_overridden_renderer_factory->get_renderer()
• line 1006 of /lib/pagelib.php: call to theme_config->get_renderer()
• line 80 of /local/moodlecheck/cli/moodlecheck.php: call to moodle_page->get_renderer()

The workaround is to install the bundled local_moodlecheck plugin into the Moodle where I'm running the tests.

[kabalin]

Hi @tim1mw, can you please provide more details on this, which version of Moodle, what plugin, steps to replicate.

[tim1mw]

Steps to reproduce:

Install using:

php composer.phar create-project moodlehq/moodle-plugin-ci ../moodle-plugin-ci ^4

(as per the instructions on: https://moodlehq.github.io/moodle-plugin-ci/)
Run the code checker from inside Moodle installation:

php ../moodle-plugin-ci/bin/moodle-plugin-ci phpdoc mod/quiz/

It will crash with the previously reported error testing any plugin.

I tried it with Moodle 4.1 and 4.5 at the time this issue was submitted and got the same crash with both. I have just re-tested using Moodle 4.5.2 and v4.5.7 of the checker and can confirm this bug still exits. As before copying the bundled moodlecheck local plugin from vendor/moodlehq/moodle-local_moodlecheck/ into moodle/local/moodlecheck directory and installing it fixed the crash. The re-test gave different line numbers in Moodle 4.5.2, but was similar:

RUN Moodle PHPDoc Checker on mod_quiz
Default exception handler: Coding error detected, it must be fixed by a programmer: Invalid component specified in renderer request Debug: local_moodlecheck
Error code: codingerror

• line 130 of /lib/classes/output/renderer_factory/renderer_factory_base.php: core\exception\coding_exception thrown
• line 65 of /lib/classes/output/renderer_factory/theme_overridden_renderer_factory.php: call to core\output\renderer_factory\renderer_factory_base->standard_renderer_classnames()
• line 2167 of /lib/classes/output/theme_config.php: call to core\output\renderer_factory\theme_overridden_renderer_factory->get_renderer()
• line 1010 of /lib/pagelib.php: call to core\output\theme_config->get_renderer()
• line 80 of /local/moodlecheck/cli/moodlecheck.php: call to moodle_page->get_renderer()

!!! Coding error detected, it must be fixed by a programmer: Invalid component specified in renderer request !!!
!! local_moodlecheck
Error code: codingerror !!
!! Stack trace: * line 130 of /lib/classes/output/renderer_factory/renderer_factory_base.php: core\exception\coding_exception thrown

• line 65 of /lib/classes/output/renderer_factory/theme_overridden_renderer_factory.php: call to core\output\renderer_factory\renderer_factory_base->standard_renderer_classnames()
• line 2167 of /lib/classes/output/theme_config.php: call to core\output\renderer_factory\theme_overridden_renderer_factory->get_renderer()
• line 1010 of /lib/pagelib.php: call to core\output\theme_config->get_renderer()
• line 80 of /local/moodlecheck/cli/moodlecheck.php: call to moodle_page->get_renderer()
  !!

I did observe that if I then deleted local/moodlecheck from the Moodle installation, without running a proper uninstall the code checker continued to work as expected, so I suspect the problem here is that it needs to have an entry in the database saying it's installed, but isn't dependent on the code being present in the Moodle codebase.