Skip to content

MOBILE-2234 quiz: Always show radio buttons on multiple choice #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2017
Merged

MOBILE-2234 quiz: Always show radio buttons on multiple choice #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion www/addons/mod/quiz/templates/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ <h2>{{ 'mma.mod_quiz.summaryofattempts' | translate }}</h2>
</div>

<!-- Result info -->
<div class="card" ng-if="showResults">
<div class="card" ng-if="showResults && (gradeResult || gradeOverridden || gradebookFeedback || (quiz.showFeedbackColumn && overallFeedback))">
<p class="item item-text-wrap" ng-if="gradeResult">{{ gradeResult }}</p>
<p class="item item-text-wrap" ng-if="gradeOverridden">{{ 'mm.course.overriddennotice' | translate }}</p>
<div class="item item-text-wrap" ng-if="gradebookFeedback">
Expand Down
6 changes: 4 additions & 2 deletions www/core/components/question/scss/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ li.mm-question-answer-correct,
}

.mm-question-answer-correct .checkbox input:disabled:checked:before,
.mm-question-answer-correct .checkbox input:disabled:checked + .checkbox-icon:before {
.mm-question-answer-correct .checkbox input:disabled:checked + .checkbox-icon:before,
.mm-question-answer-correct.item-radio input:checked + .radio-content .radio-icon:before {
background-color: $mm-question-correct-color;
border-color: $mm-question-correct-color;
}
Expand All @@ -65,7 +66,8 @@ li.mm-question-answer-incorrect,
}

.mm-question-answer-incorrect .checkbox input:disabled:checked:before,
.mm-question-answer-incorrect .checkbox input:disabled:checked + .checkbox-icon:before {
.mm-question-answer-incorrect .checkbox input:disabled:checked + .checkbox-icon:before,
.mm-question-answer-incorrect.item-radio input:checked + .radio-content .radio-icon:before {
background-color: $mm-question-incorrect-color;
border-color: $mm-question-incorrect-color;
}
Expand Down
47 changes: 47 additions & 0 deletions www/core/scss/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,6 +1036,53 @@ mm-multiple-select {
border-radius: 0;
}

.item-radio .radio-icon {
width: 28px;
height: 28px;
padding: 0;
display: block;
border: 0;
background: transparent;
cursor: pointer;
-webkit-appearance: none;
top: 14px;
right: 14px;
visibility: visible;

&:before {
border: 1px solid #ddd;
display: table;
width: 100%;
height: 100%;
border-radius: 28px;
background: white;
-webkit-transition: background-color 20ms ease-in-out;
transition: background-color 20ms ease-in-out;
content: ' ';
}

&:after {
@include transition(opacity .05s ease-in-out);
@include rotate(-45deg);
position: absolute;
top: 33%;
left: 25%;
display: table;
width: ($checkbox-width / 2);
height: ($checkbox-width / 4) - 1;
border: $checkbox-check-width solid $checkbox-check-color;
border-top: 0;
border-right: 0;
content: ' ';
}
}

.item-radio input:checked + .radio-content .radio-icon:before {
background: $checkbox-on-bg-positive;
border-color: $checkbox-off-border-positive;
}


input[type="radio"].mm-radio {
position: relative;
width: $checkbox-width;
Expand Down