Skip to content

MOBILE-3005 docker: Do not install cordova on docker #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2019
Merged

MOBILE-3005 docker: Do not install cordova on docker #1892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,17 @@ EXPOSE 35729
# Port 53703 is the Chrome dev logger port.
EXPOSE 53703

# MoodleMobile uses Cordova, Ionic, and Gulp.
RUN npm install -g cordova ionic gulp && rm -rf /root/.npm
# MoodleMobile uses Ionic and Gulp.
RUN npm i -g ionic gulp && rm -rf /root/.npm

WORKDIR /app

COPY . /app

# The setup script will handle npm installation, cordova setup, and gulp setup.
RUN npm run setup && rm -rf /root/.npm
# Install npm libraries and run gulp to initialize the project.
RUN npm install && gulp && rm -rf /root/.npm

RUN ionic info

# Provide a Healthcheck command for easier use in CI.
HEALTHCHECK --interval=10s --timeout=3s --start-period=30s CMD curl -f http://localhost:8100 || exit 1
Expand Down