Skip to content

MOBILE-3040 submission: Fix isSubmissionEmpty logic #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019
Merged

MOBILE-3040 submission: Fix isSubmissionEmpty logic #2215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/addon/mod/assign/providers/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,15 @@ export class AddonModAssignHelperProvider {
return true;
}

return !!submission.plugins.find((plugin) => this.submissionDelegate.isPluginEmpty(assign, plugin));
for (const plugin of submission.plugins) {
// If any plugin is not empty, we consider that the submission is not empty either.
if (!this.submissionDelegate.isPluginEmpty(assign, plugin)) {
return false;
}
}

// If all the plugins were empty (or there were no plugins), we consider the submission to be empty.
return true;
}

/**
Expand Down