Mobile 3188 #2493
Merged
Mobile 3188 #2493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds optional component and componentId fields to the preSets variable, which are recorded in the wscache table. These are then used by (a) core site plugins where a module cmid is available, and (b) the forum (as an example core implementation) so that module site plugins and forum provide the new data. (Note that this is not going to be very useful where we retrieve data for multiple activities at once, which happens for activities like Page. Still, it is optional.)
When showing downloaded sizes in the context menu and in the 'Manage storage' screen, show the total size including downloaded files plus cached web service data. When deleting the downloaded data in either location, delete both kinds of data.
Changes the two settings pages that show the size of a site (from the main menu, these are 'App settings / Space usage' and 'Preferences') so that they: a) do not show the number of cache entries (not very informative for end users) b) show an estimate for 'space usage' that includes the total size of data in ws_cache The space usage estimate is not perfect (it doesn't include the per-row overhead in the ws_cache table, or other cached data that can be deleted such as calendar events or user data) but it will probably be good enough, and I don't think the 'number of entries' things was helpful to anyone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.