Skip to content

MOBILE-1316 courses: Fix repeated addons in courses delegate #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2015
Merged

MOBILE-1316 courses: Fix repeated addons in courses delegate #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions www/core/components/courses/services/delegate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,18 +176,14 @@ angular.module('mm.core.courses')
* @protected
*/
self.updateNavHandlersForCourse = function(courseId) {
var promises = [];

$mmUtil.emptyArray(coursesHandlers[courseId]);
var promises = [],
enabledForCourse = [];

angular.forEach(enabledNavHandlers, function(handler) {
// Checks if the handler is enabled for the user.
var promise = $q.when(handler.instance.isEnabledForCourse(courseId)).then(function(enabled) {
if (enabled) {
coursesHandlers[courseId].push({
controller: handler.instance.getController(courseId),
priority: handler.priority
});
enabledForCourse.push(handler);
} else {
return $q.reject();
}
Expand All @@ -202,6 +198,15 @@ angular.module('mm.core.courses')
}).catch(function() {
// Never fails.
return true;
}).finally(function() {
// Update the coursesHandlers array with the new enabled addons.
$mmUtil.emptyArray(coursesHandlers[courseId]);
angular.forEach(enabledForCourse, function(handler) {
coursesHandlers[courseId].push({
controller: handler.instance.getController(courseId),
priority: handler.priority
});
});
});
};

Expand Down