Mobile 4065 #3550
Merged
Mobile 4065 #3550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazyserver
force-pushed
the
MOBILE-4065
branch
from
8494f3b to
f530bc3
Compare
crazyserver
force-pushed
the
MOBILE-4065
branch
from
f530bc3 to
a6de01f
Compare
Contributor
|
Hi @crazyserver , the code looks good to me but I have a question: I cannot see the relation between the following commit name and the changes done in the commit: Add aria-role region to headings order In the commit you just add a labelledby, so I don't know why the commit name talks about aria-role. |
crazyserver
commented
Feb 17, 2023
dpalou
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.