Skip to content

MOBILE-1457 courses: Fix courses filter #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2016
Merged

MOBILE-1457 courses: Fix courses filter #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion www/core/components/courses/controllers/list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ angular.module('mm.core.courses')

$scope.searchEnabled = $mmCourses.isSearchCoursesAvailable();
$scope.areNavHandlersLoadedFor = $mmCoursesDelegate.areNavHandlersLoadedFor;
$scope.filter = {};

// Convenience function to fetch courses.
function fetchCourses(refresh) {
Expand All @@ -34,7 +35,7 @@ angular.module('mm.core.courses')
angular.forEach(courses, function(course) {
course._handlers = $mmCoursesDelegate.getNavHandlersFor(course.id, refresh);
});
$scope.filterText = ''; // Filter value MUST be set after courses are shown.
$scope.filter.filterText = ''; // Filter value MUST be set after courses are shown.
}, function(error) {
if (typeof error != 'undefined' && error !== '') {
$mmUtil.showErrorModal(error);
Expand Down
4 changes: 2 additions & 2 deletions www/core/components/courses/templates/list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
<div class="list" ng-if="courses && courses.length > 5">
<label class="item item-input">
<i class="icon ion-funnel placeholder-icon"></i>
<input type="text" placeholder="{{ 'mm.courses.filtermycourses' | translate}}" ng-model="filterText">
<input type="text" placeholder="{{ 'mm.courses.filtermycourses' | translate}}" ng-model="filter.filterText">
</label>
</div>
<section ng-repeat="course in courses | filter:{fullname: filterText}" class="list card">
<section ng-repeat="course in courses | filter:{fullname: filter.filterText}" class="list card">
<a class="item" ui-sref="site.mm_course({courseid: course.id})" title="{{course.fullname}}">
<h2><mm-format-text watch="true">{{course.fullname}}</mm-format-text></h2>
</a>
Expand Down