Skip to content

MOBILE-1595 cbe: Hide activity icons while iconurl is not correct #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2016
Merged

MOBILE-1595 cbe: Hide activity icons while iconurl is not correct #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions www/addons/competency/templates/competency.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@
</span>
<ul ng-if="coursemodules.length > 0">
<li ng-repeat="activity in coursemodules">
<a mm-link capture-link="true" class="item item-text-wrap mm-course-module-handler item-media" href="{{ activity.url }}" title="{{ activity.name }}">
<img ng-src="{{ activity.iconurl }}" mm-external-content alt="" role="presentation" ng-if="activity.iconurl">
<a mm-link capture-link="true" class="item item-text-wrap mm-course-module-handler" href="{{ activity.url }}" title="{{ activity.name }}">
<mm-format-text watch="true">{{ activity.name }}</mm-format-text>
</a>
</li>
Expand Down
3 changes: 1 addition & 2 deletions www/addons/competency/templates/coursecompetencies.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ <h3>{{ 'mma.competency.competencies' | translate }}</h3>
</span>
<ul ng-if="competency.coursemodules.length > 0">
<li ng-repeat="activity in competency.coursemodules">
<a mm-link capture-link="true" class="item item-text-wrap mm-course-module-handler item-media" href="{{ activity.url }}" title="{{ activity.name }}">
<img ng-src="{{ activity.iconurl }}" mm-external-content alt="" role="presentation" ng-if="activity.iconurl">
<a mm-link capture-link="true" class="item item-text-wrap mm-course-module-handler" href="{{ activity.url }}" title="{{ activity.name }}">
<mm-format-text watch="true">{{ activity.name }}</mm-format-text>
</a>
</li>
Expand Down