Skip to content

fix warnings #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

fix warnings #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion moon.mod.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rami3l/js-ffi",
"version": "0.1.6",
"version": "0.1.7",
"readme": "README.md",
"repository": "",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion src/js/async_test.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ async fn op1() -> String? {

///|
async fn op2() -> String? {
guard let Some(prefix) = op1!!()
guard op1!!() is Some(prefix)
Some(prefix + ", World")
}

Expand Down
8 changes: 5 additions & 3 deletions src/js/error.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ pub impl Show for Error_ with output(self, logger) {
logger.write_string("@js.Error: ")
let Error_(inner) = self
logger.write_object(inner)
guard let Some(cause_inner) = self.cause() else { _ => return }
guard self.cause() is Some(cause_inner) else { return }
logger.write_string("\n caused by:\n")
logger.write_object(cause_inner)
}
Expand All @@ -37,6 +37,8 @@ pub fn Error_::wrap[T](
) -> T!Error_ {
let mut res : Result[Value, Error_] = Ok(Value::undefined())
Error_::wrap_ffi(op, fn(v) { res = Ok(v) }, fn(e) { res = Err(Error_(e)) })
guard let Ok(v) = res else { Err(e) => raise e }
map_ok(v)
match res {
Ok(v) => map_ok(v)
Err(e) => raise e
}
}