panic instead of raise error on bad spawn #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawning on calling
add_deferon an already terminated task group is an error. Previously this is handled via raising@async.AlreadyTerminated, but this is not the most appropriate solution. This kind of bad spawn are always programmer bug, with very clear pattern. So the most appropriate solution is topanicon bad spawn. This also allows removing theraisemark from the spawn functions, allowing them to be called in contexts that disallow error.The
AlreadyTerminatederror become useless now, and is deprecated.