fix: Some final polish before beta release. (#2)

milesj · web-flow · commit ea37025cab6b · 2022-08-15T23:42:37.000-07:00
* Polish readmes.

* Fixes.

* Enable tracing.

* Move vcs config.

* Add fetch depth.

* Add build.

* Add build deps to all tasks.

* Fix typecheck.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -14,6 +14,8 @@ jobs:
       fail-fast: true
     steps:
       - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
       - uses: actions/setup-node@v3
         with:
           cache: yarn
@@ -22,4 +24,5 @@ jobs:
         with:
           node: ${{ matrix.node-version }}
       - run: yarn install --immutable
+      - run: yarn build
       - run: yarn moon ci
diff --git a/.moon/oss/project-packages.yml b/.moon/oss/project-packages.yml
@@ -50,6 +50,8 @@ tasks:
       - '@in(3)'
       - '--check'
       - '.'
+    deps:
+      - '^:build'
     inputs:
       - '@globs(sources)'
       - '@globs(tests)'
@@ -72,6 +74,8 @@ tasks:
       - '--ignore-path'
       - '@in(4)'
       - '.'
+    deps:
+      - '^:build'
     inputs:
       - '@globs(sources)'
       - '@globs(tests)'
@@ -83,6 +87,8 @@ tasks:
   # https://moonrepo.dev/docs/guides/examples/jest
   test:
     command: 'jest'
+    deps:
+      - '^:build'
     args:
       - '--coverage'
       - '--passWithNoTests'
@@ -97,11 +103,11 @@ tasks:
     args:
       - '--build'
       - '--pretty'
+    deps:
+      - '^:build'
     inputs:
       - '@globs(sources)'
       - '@globs(tests)'
       - 'tsconfig.json'
       - 'tsconfig.*.json'
       - '/tsconfig.options.json'
-    outputs:
-      - 'dts'
diff --git a/README.md b/README.md
@@ -2,13 +2,13 @@
 
 [![Build Status](https://github.com/moonrepo/dev/workflows/Pipeline/badge.svg)](https://github.com/moonrepo/dev/actions?query=branch%3Amaster)
 [![npm version](https://badge.fury.io/js/%40moonrepo%dev.svg)](https://www.npmjs.com/package/@moonrepo/dev)
-[![npm deps](https://david-dm.org/moonrepo/dev.svg?path=packages/dev)](https://www.npmjs.com/package/@moon/dev)
 
 This repository is a collection of moon owned and maintained configurations and presets for common
 developer tools -- primarily tools used by moonrepo and its authors.
 
 It aims to provide a strict, modern, developer accessible, convention over configuration approach to
-JavaScript, TypeScript, and React projects!
+JavaScript, TypeScript, and React projects! All of these configs have been designed for local and
+developer tooling based development!
 
 ## Packages
 
@@ -31,9 +31,9 @@ and more. This should rarely be used directly!
 
 ## Contributing
 
-So... all these configs are personal preference and won't change drastically. You're welcome to use
-them as-is, but changes are unlikely to land. Feel free to create an issue otherwise so that we can
-discuss the intended change.
+All these configs are personal preference and won't change drastically. You're welcome to use them
+as-is, but major changes are unlikely to land. Feel free to create an issue otherwise so that we can
+discuss any intended change.
 
 ### Why tabs over spaces?
 
diff --git a/package.json b/package.json
@@ -2,7 +2,8 @@
   "private": true,
   "name": "moon-dev",
   "scripts": {
-    "moon": "$(yarn bin moon)",
+    "build": "packemon build",
+    "moon": "$(yarn bin moon) --color",
     "prerelease": "node scripts/releaseCheck.mjs && yarn run pack && yarn run check",
     "release": "yarn prerelease && lerna version --conventional-commits --changelog-preset conventional-changelog-beemo --create-release github --push && lerna publish from-git",
     "setup": "yarn moon run :build",
@@ -13,12 +14,12 @@
   ],
   "devDependencies": {
     "@babel/core": "^7.18.10",
-    "@moonrepo/cli": "^0.10.0",
+    "@moonrepo/cli": "^0.11.1",
     "conventional-changelog-beemo": "^3.0.1",
     "eslint": "^8.20.0",
     "jest": "^28.1.3",
     "jest-circus": "^28.1.3",
-    "lerna": "^5.2.0",
+    "lerna": "^5.4.2",
     "packemon": "^2.3.3",
     "prettier": "^2.7.1",
     "typescript": "^4.7.4"
diff --git a/packages/babel-preset/README.md b/packages/babel-preset/README.md
@@ -2,7 +2,6 @@
 
 [![Build Status](https://github.com/moonrepo/dev/workflows/Pipeline/badge.svg)](https://github.com/moonrepo/dev/actions?query=branch%3Amaster)
 [![npm version](https://badge.fury.io/js/babel-preset-moon.svg)](https://www.npmjs.com/package/babel-preset-moon)
-[![npm deps](https://david-dm.org/moonrepo/dev.svg?path=packages/babel-preset)](https://www.npmjs.com/package/babel-preset-moon)
 
 A modern Babel preset with built-in TypeScript support. Is designed for unit testing, linting, and
 local development only -- it _should not_ be used for web applications or package building (use
diff --git a/packages/babel-preset/package.json b/packages/babel-preset/package.json
@@ -1,7 +1,7 @@
 {
   "name": "babel-preset-moon",
   "version": "0.0.0",
-  "description": "Babel preset for tooling development.",
+  "description": "A modern Babel preset for tooling development.",
   "keywords": [
     "babel-preset",
     "moon",
diff --git a/packages/dev/README.md b/packages/dev/README.md
@@ -2,6 +2,5 @@
 
 [![Build Status](https://github.com/moonrepo/dev/workflows/Pipeline/badge.svg)](https://github.com/moonrepo/dev/actions?query=branch%3Amaster)
 [![npm version](https://badge.fury.io/js/%40moonrepo%dev.svg)](https://www.npmjs.com/package/@moonrepo/dev)
-[![npm deps](https://david-dm.org/moonrepo/dev.svg?path=packages/dev)](https://www.npmjs.com/package/@moonrepo/dev)
 
 Reusable constants and helpers for moon configurations. This shouldn't be used directly.
diff --git a/packages/eslint-config/README.md b/packages/eslint-config/README.md
@@ -2,11 +2,11 @@
 
 [![Build Status](https://github.com/moonrepo/dev/workflows/Pipeline/badge.svg)](https://github.com/moonrepo/dev/actions?query=branch%3Amaster)
 [![npm version](https://badge.fury.io/js/eslint-config-moon.svg)](https://www.npmjs.com/package/eslint-config-moon)
-[![npm deps](https://david-dm.org/moonrepo/dev.svg?path=packages/eslint-config)](https://www.npmjs.com/package/eslint-config-moon)
 
-A modern TypeScript-only ESLint config with optional presets. Expands upon the amazing
-[Airbnb config](https://www.npmjs.com/package/eslint-config-airbnb-base) to provide the latest
-ECMAScript features, enforce popular patterns, and align with the wider community.
+A modern and strict ESLint configuration with optional presets and first-class TypeScript support.
+Expands upon the amazing [Airbnb config](https://www.npmjs.com/package/eslint-config-airbnb-base) to
+provide the latest ECMAScript features, enforce popular patterns, and align with the wider
+community.
 
 ```bash
 yarn install --dev eslint eslint-config-moon
@@ -39,7 +39,7 @@ The following additional configs can also be extended, but are not enabled by de
   [react-perf](https://www.npmjs.com/package/eslint-plugin-react-perf), and
   [jsx-a11y](https://www.npmjs.com/package/eslint-plugin-jsx-a11y) plugins.
   - Only applies to `*.tsx` files and also extends the `browser` preset.
-  - Enables automatic JSX runtime if root `react` version is 17+.
+  - Enables automatic JSX runtime if `react` version is 17+.
 
 ## Features
 
diff --git a/packages/eslint-config/package.json b/packages/eslint-config/package.json
@@ -1,7 +1,7 @@
 {
   "name": "eslint-config-moon",
   "version": "0.0.0",
-  "description": "Reusable ESLint config for moon configured projects.",
+  "description": "A modern and strict ESLint configuration.",
   "keywords": [
     "eslint-config",
     "airbnb",
diff --git a/packages/jest-preset/README.md b/packages/jest-preset/README.md
@@ -2,7 +2,6 @@
 
 [![Build Status](https://github.com/moonrepo/dev/workflows/Pipeline/badge.svg)](https://github.com/moonrepo/dev/actions?query=branch%3Amaster)
 [![npm version](https://badge.fury.io/js/jest-preset-moon.svg)](https://www.npmjs.com/package/jest-preset-moon)
-[![npm deps](https://david-dm.org/moonrepo/dev.svg?path=packages/babel-preset)](https://www.npmjs.com/package/jest-preset-moon)
 
 A modern Jest preset that provides code coverage and performance out of the box.
 
diff --git a/packages/jest-preset/jest-preset.js b/packages/jest-preset/jest-preset.js
@@ -0,0 +1 @@
+module.exports = require('./lib');
diff --git a/packages/jest-preset/package.json b/packages/jest-preset/package.json
@@ -1,7 +1,7 @@
 {
   "name": "jest-preset-moon",
   "version": "0.0.0",
-  "description": "Jest preset for moon configured projects.",
+  "description": "A modern Jest preset for tooling development.",
   "keywords": [
     "jest-preset",
     "moon"
@@ -10,6 +10,7 @@
   "types": "./dts/index.d.ts",
   "files": [
     "dts/**/*.d.ts",
+    "jest-preset.js",
     "lib/**/*.{js,map}",
     "src/**/*.{ts,tsx,json}"
   ],
diff --git a/packages/jest-preset/tsconfig.json b/packages/jest-preset/tsconfig.json
@@ -6,7 +6,8 @@
   "include": [
     "src/**/*",
     "tests/**/*",
-    "jest.config.js"
+    "jest.config.js",
+    "jest-preset.js"
   ],
   "references": [
     {
diff --git a/packages/prettier-config/README.md b/packages/prettier-config/README.md
@@ -2,17 +2,16 @@
 
 [![Build Status](https://github.com/moonrepo/dev/workflows/Pipeline/badge.svg)](https://github.com/moonrepo/dev/actions?query=branch%3Amaster)
 [![npm version](https://badge.fury.io/js/prettier-config-moon.svg)](https://www.npmjs.com/package/prettier-config-moon)
-[![npm deps](https://david-dm.org/moonrepo/dev.svg?path=packages/prettier-config)](https://www.npmjs.com/package/prettier-config-moon)
 
-A modern and strict Prettier config that aligns with the community.
+A modern and accessibility forward Prettier config that aligns with the community.
 
 ```bash
 yarn install --dev prettier-config-moon
 ```
 
 ## Setup
 
-Extend the config from your root `prettier.config.js`.
+Extend the config from your root `prettier.config.js` or `.prettierrc.js`.
 
 ```js
 module.exports = 'prettier-config-moon';
diff --git a/packages/tsconfig/README.md b/packages/tsconfig/README.md
@@ -2,10 +2,9 @@
 
 [![Build Status](https://github.com/moonrepo/dev/workflows/Pipeline/badge.svg)](https://github.com/moonrepo/dev/actions?query=branch%3Amaster)
 [![npm version](https://badge.fury.io/js/tsconfig-moon.svg)](https://www.npmjs.com/package/tsconfig-moon)
-[![npm deps](https://david-dm.org/moonrepo/dev.svg?path=packages/tsconfig)](https://www.npmjs.com/package/tsconfig-moon)
 
-Pre-packaged and modern TypeScript `tsconfig.json`s. Each config assumes that TypeScript will _only_
-be used as a type checker and _not_ a compiler.
+Pre-packaged, strict, and modern TypeScript `tsconfig.json`s. Each config assumes that TypeScript
+will _only_ be used as a type checker and _not_ a compiler.
 
 ```bash
 yarn install --dev tsconfig-moon
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "babel-preset-moon",`
`3`	`3`	`"version": "0.0.0",`
`4`		`- "description": "Babel preset for tooling development.",`
	`4`	`+ "description": "A modern Babel preset for tooling development.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"babel-preset",`
`7`	`7`	`"moon",`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "eslint-config-moon",`
`3`	`3`	`"version": "0.0.0",`
`4`		`- "description": "Reusable ESLint config for moon configured projects.",`
	`4`	`+ "description": "A modern and strict ESLint configuration.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"eslint-config",`
`7`	`7`	`"airbnb",`