Skip to content

Refactor deps command#2152

Merged
jodal merged 1 commit intomopidy:developfrom
jodal:deps-refactor
Feb 23, 2024
Merged

Refactor deps command#2152
jodal merged 1 commit intomopidy:developfrom
jodal:deps-refactor

Conversation

@jodal
Copy link
Copy Markdown
Member

@jodal jodal commented Feb 23, 2024 •
edited
Loading

  • Do not repeat transitive dependencies.
  • Refactor to use dataclass instead of dicts.
--- before.txt  2024-02-23 19:58:31.779994186 +0100
+++ after.txt   2024-02-23 19:58:37.528000081 +0100
@@ -1,7 +1,7 @@
 Executable: /home/jodal/mopidy-dev/.venv/bin/mopidy
 Platform: Linux-6.6.15-amd64-x86_64-with-glibc2.37
 Python: CPython 3.11.8 from /usr/lib/python3.11
-Mopidy: 4.0.0a1 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
+mopidy: 4.0.0a1 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
   pygobject: 3.46.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
     pycairo: 1.26.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
   pykka: 4.0.2 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
@@ -13,31 +13,14 @@
     certifi: 2024.2.2 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
   setuptools: 69.1.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
   tornado: 6.4 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-Mopidy-MPD: 4.0.0a1 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
+mopidy-mpd: 4.0.0a1 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
   mopidy: 4.0.0a1 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-    pygobject: 3.46.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-      pycairo: 1.26.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-    pykka: 4.0.2 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-      typing-extensions: 4.9.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-    requests: 2.31.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-      charset-normalizer: 3.3.2 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-      idna: 3.6 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-      urllib3: 2.2.1 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-      certifi: 2024.2.2 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-    setuptools: 69.1.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-    tornado: 6.4 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
   pykka: 4.0.2 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-    typing-extensions: 4.9.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
   setuptools: 69.1.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-Mopidy-Spotify: 4.1.1 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-  Mopidy: 4.0.0a1 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-  Pykka: 4.0.2 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-    typing-extensions: 4.9.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
+mopidy-spotify: 4.1.1 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
+  mopidy: 4.0.0a1 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
+  pykka: 4.0.2 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
   requests: 2.31.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-    charset-normalizer: 3.3.2 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-    idna: 3.6 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-    urllib3: 2.2.1 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
-    certifi: 2024.2.2 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
   setuptools: 69.1.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages
 GStreamer: 1.22.10.0 from /home/jodal/mopidy-dev/.venv/lib/python3.11/site-packages/gi
   Detailed information:

@jodal
Refactor deps command
21c6a9f 
- Do not repeat transitive dependencies.
- Refactor to use dataclass instead of dicts.
@jodal jodal enabled auto-merge February 23, 2024 19:02
@jodal jodal merged commit b70fef8 into mopidy:develop Feb 23, 2024
@jodal jodal deleted the deps-refactor branch February 23, 2024 19:03
@jodal jodal added this to the v4.0.0 milestone Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@jodal