code refactoring #129
Merged
code refactoring #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chfw
commented
Nov 15, 2018
chfw
commented
- optimize handlebar code where the hbr template can be reused
- reuse code in base engine
- re-shuffle the code location so that each code finds its own place.
…ks but relocating it to moban.jinja2.extension wont do
Member
Author
|
@CLiu13 please review. |
Codecov Report
@@ Coverage Diff @@
## dev #129 +/- ##
=========================================
- Coverage 98.59% 98.29% -0.3%
=========================================
Files 39 38 -1
Lines 1921 1877 -44
=========================================
- Hits 1894 1845 -49
- Misses 27 32 +5
Continue to review full report at Codecov.
|
ayan-b
pushed a commit
to ayan-b/moban
that referenced
this pull request
Jan 15, 2019
* 🔨 code refactoring * 🔨 format code * 🔨 pump up the version * 💚 fix the problem with the import. mysteriously, moban.extensions works but relocating it to moban.jinja2.extension wont do * 🔨 code refactoring * ✨ code refactoring * 🔨 code refactoring on jinja2 engine * 🔨 code refactoring * 🔨 load handle_bar by default for now * 💚 include pybars3 as temp requirements to pass unit tests * 🐛 fix a typo * 🔨 allow base engine to have constructor that has more shared code * :tructor: rename engine_factory * 🔨 code refactor jinja2 engine * 🔥 remove duplicated find template file * 🔥 remove useless function * 🔥 remove logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.