Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Nov 17, 2018

jinja2 things in jinja2 folder

@chfw chfw requested review from PrajwalM2212 and jayvdb November 17, 2018 16:31
@codecov-io
Copy link

codecov-io commented Nov 17, 2018

Codecov Report

Merging #132 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #132      +/-   ##
==========================================
+ Coverage   98.74%   98.74%   +<.01%     
==========================================
  Files          40       41       +1     
  Lines        1828     1836       +8     
==========================================
+ Hits         1805     1813       +8     
  Misses         23       23
Impacted Files Coverage Δ
moban/jinja2/extensions.py 100% <ø> (ø)
tests/test_engine.py 100% <ø> (ø) ⬆️
moban/jinja2/filters/repr.py 100% <100%> (ø) ⬆️
moban/plugins.py 97.03% <100%> (-0.34%) ⬇️
moban/jinja2/filters/text.py 100% <100%> (ø) ⬆️
moban/jinja2/tests/files.py 100% <100%> (ø) ⬆️
moban/jinja2/filters/github.py 96.96% <100%> (ø) ⬆️
tests/test_handlebar_engine.py 100% <100%> (ø) ⬆️
moban/main.py 100% <100%> (ø) ⬆️
moban/engine_handlebars.py 100% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d7fed...fa9f9da. Read the comment docs.

@chfw chfw merged commit 72ae965 into dev Nov 17, 2018
@chfw chfw deleted the jinja2-optimization branch January 5, 2019 20:43
ayan-b pushed a commit to ayan-b/moban that referenced this pull request Jan 15, 2019
* 🔨 further optimization. all jinja2 related code should go in jinja2 folder

* 🚜 all jinja2 extensions shall live in jinja2 folder.

* :micrscope: add jinja2 extensions test

* 💚 keep two stage lml loading. Althrough it is not yet understood why, it works.

* 🐛 fix loading bug. otherwise, Error: jinja2

* 📚 make notes on critical code lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants