Separate handlebars #134
Separate handlebars #134
Conversation
… and remove pybars3
…when the hash is calculated but is removed when saving the files. hence moban think the file is always updated. 🔥 remove engine handlebars loading
Codecov Report
@@ Coverage Diff @@
## dev #134 +/- ##
==========================================
- Coverage 98.74% 98.44% -0.31%
==========================================
Files 41 39 -2
Lines 1836 1800 -36
==========================================
- Hits 1813 1772 -41
- Misses 23 28 +5
Continue to review full report at Codecov.
|
CLiu13
left a comment
CLiu13
left a comment
There was a problem hiding this comment.
Also, don't forget to update the changelog :)
| Level 11: use handlebars | ||
| ================================================================================ | ||
|
|
||
| moban is extensible via lml. Charlie Liu through google code in 2018 has |
There was a problem hiding this comment.
google code in -> Google Code-in
There was a problem hiding this comment.
Also, thanks for the shoutout :)
There was a problem hiding this comment.
That's the least I could do.
| Please go to `docs/level-11-use-handlebars` directory. | ||
|
|
||
|
|
||
| Here is the `.moban.yml`, whihc replaces the command in level 3:: |
| 'sphinx.ext.intersphinx', | ||
| 'sphinx.ext.viewcode', | ||
| ] | ||
| extensions = [ 'sphinx.ext.autodoc', 'sphinx.ext.doctest', 'sphinx.ext.intersphinx', 'sphinx.ext.viewcode',] |
There was a problem hiding this comment.
Is this format intentional? Used to be a list with each element separated by a newline.
There was a problem hiding this comment.
this one comes from pypi-mobans-pkg, which then comes from sphinx project. The fix is better to come from there.
* 🔥 separate handlebars to moban-handlebars * 🐛 fix get_primary_key will fail when a module is loaded later. fix moremoban#8. and remove pybars3 * 📚 update handlebars usage * 🐛 moban hash does not work because trailing new line was not removed when the hash is calculated but is removed when saving the files. hence moban think the file is always updated. 🔥 remove engine handlebars loading * 📚 update conf.py from pypi-mobans-pkg * 💚 use moban-handlebars git repo for testing * 📚 update change log, docs and correct typepos
@CLiu13, Please review it. And I will make a release 0.3.4.
The build will become green when https://github.com/moremoban/moban-handlebars will be released.
So please review moban-handlebars too.