Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Jan 5, 2019

the report case is related to #150 when moban detects that no need to apply templating.

$ moban -t abc.jj2

change from

Info: Both data.yml and /private/tmp/.moban.cd/data.yml does not exist
Warning: Attempting to use environment vars as data...

to

Info: Both data.yml and /private/tmp/.moban.cd/data.yml does not exist
Warning: Attempting to use environment vars as data...
No templating

@chfw chfw requested review from CLiu13, PrajwalM2212 and jayvdb January 5, 2019 18:04
@codecov-io
Copy link

codecov-io commented Jan 5, 2019

Codecov Report

Merging #152 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #152      +/-   ##
=========================================
+ Coverage   97.89%   97.9%   +<.01%     
=========================================
  Files          40      40              
  Lines        1951    1957       +6     
=========================================
+ Hits         1910    1916       +6     
  Misses         41      41
Impacted Files Coverage Δ
moban/main.py 100% <100%> (ø) ⬆️
moban/plugins.py 96.55% <100%> (+0.04%) ⬆️
tests/test_docs.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd78f63...16b9f08. Read the comment docs.

Copy link
Collaborator

@CLiu13 CLiu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chfw chfw merged commit 0ea6326 into dev Jan 5, 2019
@chfw chfw deleted the single-file-report branch January 5, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants