Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Jan 10, 2019

fix #155
fix #154

@chfw chfw requested review from CLiu13 and PrajwalM2212 January 10, 2019 18:19
@codecov-io
Copy link

codecov-io commented Jan 10, 2019

Codecov Report

Merging #159 into dev will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #159      +/-   ##
==========================================
+ Coverage   98.02%   98.06%   +0.04%     
==========================================
  Files          40       40              
  Lines        1973     2020      +47     
==========================================
+ Hits         1934     1981      +47     
  Misses         39       39
Impacted Files Coverage Δ
moban/_version.py 100% <100%> (ø) ⬆️
moban/main.py 100% <100%> (ø) ⬆️
...sts/integration_tests/test_command_line_options.py 98.3% <100%> (+0.05%) ⬆️
tests/test_engine.py 100% <100%> (ø) ⬆️
tests/test_jinja2_engine.py 100% <100%> (ø) ⬆️
moban/jinja2/engine.py 100% <100%> (ø) ⬆️
moban/plugins.py 98.08% <100%> (+0.17%) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce73e5a...7909bc9. Read the comment docs.

Copy link
Collaborator

@CLiu13 CLiu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chfw chfw merged commit 32c14eb into dev Jan 11, 2019
@chfw chfw deleted the handle-missing-template branch January 11, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README should be updated when environment variable is taken into template use template string as an input for '-t'

5 participants