Skip to content

Conversation

@ayan-b
Copy link
Member

@ayan-b ayan-b commented Jan 15, 2019

The extensions are expression-statement and loop-controls

Related to #90

Before raising the PR, here is a check list:

  1. have you written unit tests for your code changes?
  2. have you run "make format"?
  3. are you requesting to "dev"?
  4. have you updated the change log?
  5. do you think that you can understand your changes after 6 month?
    5.1) can someone else understand your changes without your explanation?
  6. are you pround of your code changes?
    6.1) do you have the feeling of achievement?
  7. please add your name and github link to contributors.rst in alphabetical order.

The extensions are expression-statement and loop-controls

Related to moremoban#90
@ayan-b ayan-b changed the title engine.py: Add two default extensions [WIP] engine.py: Add two default extensions Jan 15, 2019
@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #163 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #163      +/-   ##
==========================================
+ Coverage   97.79%   97.79%   +<.01%     
==========================================
  Files          40       40              
  Lines        2043     2044       +1     
==========================================
+ Hits         1998     1999       +1     
  Misses         45       45
Impacted Files Coverage Δ
moban/jinja2/engine.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb8c747...cb1556d. Read the comment docs.

Copy link
Member

@chfw chfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one step towards the goal.

@chfw chfw merged commit 8b22bdd into moremoban:dev Jan 15, 2019
@ayan-b ayan-b deleted the addext branch April 27, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants