Skip to content

Conversation

@ayan-b
Copy link
Member

@ayan-b ayan-b commented Jan 17, 2019

Related to #90

Before raising the PR, here is a check list:

  1. have you written unit tests for your code changes?
  2. have you run "make format"?
  3. are you requesting to "dev"?
  4. have you updated the change log?
  5. do you think that you can understand your changes after 6 month?
    5.1) can someone else understand your changes without your explanation?
  6. are you pround of your code changes?
    6.1) do you have the feeling of achievement?
  7. please add your name and github link to contributors.rst in alphabetical order.

@chfw chfw merged commit 8c4c3e7 into moremoban:extensions Jan 17, 2019
@ayan-b ayan-b deleted the docs-ext branch April 27, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants