-
-
Notifications
You must be signed in to change notification settings - Fork 13
✨ Add -v to show current moban version
#179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chfw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A unit test case please!
|
I will look at the unit test failure. |
Thanks. Not sure why it is occurring. New unit test case added for this change. |
-v to show current moban version-v to show current moban version
Codecov Report
@@ Coverage Diff @@
## dev #179 +/- ##
==========================================
+ Coverage 97.82% 97.83% +<.01%
==========================================
Files 40 40
Lines 2071 2079 +8
==========================================
+ Hits 2026 2034 +8
Misses 45 45
Continue to review full report at Codecov.
|
chfw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing: update change log :)
-v to show current moban version-v to show current moban version
Done! |
chfw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTG
Closes #107
Before raising the PR, here is a check list:
5.1) can someone else understand your changes without your explanation?
6.1) do you have the feeling of achievement?