Single cli output #248
Merged
Single cli output #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. v0.4.1 or earlier, copy targets are executed in a separate handler, meaning at least the counter, the number of templated files are reset, and there will be two stastistics. And this change make cli target a clear priority. fix #180
Member
|
CI fails, restarting the job. |
Codecov Report
@@ Coverage Diff @@
## dev #248 +/- ##
=========================================
- Coverage 99.3% 99.26% -0.05%
=========================================
Files 57 57
Lines 2435 2434 -1
=========================================
- Hits 2418 2416 -2
- Misses 17 18 +1
Continue to review full report at Codecov.
|
ayan-b
reviewed
Mar 6, 2019
ayan-b
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strengthens #180
single cli output has been address previously. this PR join legacy copy targets with normal and only targets so that they are executed in the same pipe line.
what's more, code refactoring is done so that cli target is seen as top priority.