Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Mar 7, 2019

fix #244

before:

screenshot 2019-03-07 at 21 42 22

after:

screenshot 2019-03-07 at 21 41 58

@chfw chfw requested review from CLiu13, ayan-b and jayvdb March 7, 2019 21:38
@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #251 into dev will decrease coverage by 0.81%.
The diff coverage is 60.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #251      +/-   ##
==========================================
- Coverage   99.14%   98.33%   -0.82%     
==========================================
  Files          57       59       +2     
  Lines        2469     2519      +50     
==========================================
+ Hits         2448     2477      +29     
- Misses         21       42      +21
Impacted Files Coverage Δ
tests/mobanfile/test_templates.py 100% <ø> (ø) ⬆️
moban/mobanfile/templates.py 100% <100%> (ø) ⬆️
moban/plugins/template.py 97.81% <100%> (+0.01%) ⬆️
tests/test_copy_engine.py 100% <100%> (ø) ⬆️
moban/utils.py 97.64% <50%> (ø) ⬆️
tests/test_regression_pack.py 52.63% <52.63%> (ø)
moban/jinja2/tests/win32.py 66.66% <66.66%> (ø)
tests/test_hash_store.py 98.88% <75%> (-1.12%) ⬇️
moban/jinja2/tests/files.py 85.71% <80%> (-14.29%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 057cfbd...2960f23. Read the comment docs.

@chfw chfw mentioned this pull request Mar 7, 2019
@chfw chfw merged commit 651e448 into dev Mar 8, 2019
@chfw chfw deleted the symbolic-link branch March 8, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci test results on Windows OS was silenced by a mistake

4 participants