Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Mar 8, 2019

delivers #209

I am sorry for windows users who has no git. you will get stack trace. Passing shell=True to subprocess.check_output(...shell=True).. has its security risk on windows.

@chfw chfw requested review from CLiu13 and ayan-b March 8, 2019 19:46
@chfw chfw merged commit 84afbaf into dev Mar 8, 2019
@chfw chfw deleted the git-check branch March 8, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants