Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented May 20, 2019

when it passes the regression test, let's merge

@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #269 into dev will decrease coverage by 0.26%.
The diff coverage is 85.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #269      +/-   ##
==========================================
- Coverage   99.19%   98.93%   -0.27%     
==========================================
  Files          59       60       +1     
  Lines        2495     2539      +44     
==========================================
+ Hits         2475     2512      +37     
- Misses         20       27       +7
Impacted Files Coverage Δ
moban/plugins/template.py 97.82% <100%> (+0.01%) ⬆️
tests/test_copy_encoding.py 100% <100%> (ø) ⬆️
moban/utils.py 97.8% <100%> (+0.1%) ⬆️
tests/test_regression.py 80% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43efd58...ab9f52c. Read the comment docs.

@chfw chfw merged commit 2416e40 into dev May 20, 2019
@chfw chfw deleted the regression-test-coping-binary-file branch May 25, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants