Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Sep 10, 2019

Before raising the PR, here is a check list:

  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?

fix #328

@codecov-io
Copy link

codecov-io commented Sep 10, 2019

Codecov Report

Merging #329 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #329   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          51       51           
  Lines        2547     2547           
=======================================
  Hits         2429     2429           
  Misses        118      118
Impacted Files Coverage Δ
moban/_version.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62ea15...0c073aa. Read the comment docs.

@chfw chfw merged commit 0ae9ff0 into dev Sep 10, 2019
@chfw chfw deleted the quick-update branch September 19, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gitpython, git-url-parse dependencies are missing

3 participants