Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Sep 11, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?

delivers #322

@chfw chfw requested a review from jayvdb September 11, 2019 21:35
@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #331 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #331      +/-   ##
==========================================
+ Coverage   95.36%   95.37%   +0.01%     
==========================================
  Files          51       51              
  Lines        2547     2553       +6     
==========================================
+ Hits         2429     2435       +6     
  Misses        118      118
Impacted Files Coverage Δ
tests/test_docs.py 100% <ø> (ø) ⬆️
moban/definitions.py 100% <100%> (ø) ⬆️
moban/mobanfile/templates.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f0809...4a669c7. Read the comment docs.

@chfw chfw merged commit ec337d4 into dev Sep 12, 2019
@chfw chfw deleted the default-2-copy branch September 19, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants