Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Sep 13, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?

fix #333

@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #332 into dev will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #332      +/-   ##
==========================================
+ Coverage   95.37%   95.58%   +0.21%     
==========================================
  Files          51       51              
  Lines        2553     2584      +31     
==========================================
+ Hits         2435     2470      +35     
+ Misses        118      114       -4
Impacted Files Coverage Δ
moban/main.py 99.2% <100%> (+0.06%) ⬆️
moban/core/moban_factory.py 92.76% <100%> (+3.17%) ⬆️
...sts/integration_tests/test_command_line_options.py 100% <100%> (ø) ⬆️
moban/jinja2/engine.py 98.8% <100%> (+0.05%) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec337d4...ee870c2. Read the comment docs.

@chfw chfw changed the title Extension at cli (WIP) Extension at cli, -e jinja2='jinja2_python_version.PythonVersionExtension' Sep 13, 2019
@chfw chfw requested a review from ayan-b September 13, 2019 20:44
@chfw chfw merged commit 692086a into dev Sep 14, 2019
@chfw chfw deleted the extension-at-cli branch September 14, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

command line template fails with version 0.6.1

3 participants