Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Sep 19, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?

@codecov-io
Copy link

codecov-io commented Sep 19, 2019

Codecov Report

Merging #336 into dev will increase coverage by 0.08%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #336      +/-   ##
==========================================
+ Coverage   95.58%   95.67%   +0.08%     
==========================================
  Files          51       51              
  Lines        2584     2610      +26     
==========================================
+ Hits         2470     2497      +27     
+ Misses        114      113       -1
Impacted Files Coverage Δ
moban/main.py 99.22% <100%> (+0.02%) ⬆️
tests/test_main.py 100% <100%> (ø) ⬆️
...sts/integration_tests/test_command_line_options.py 99.38% <96.29%> (-0.62%) ⬇️
moban/deprecated/__init__.py 86.04% <0%> (-2.33%) ⬇️
moban/file_system.py 95.31% <0%> (-1.57%) ⬇️
tests/test_reporter.py 98.48% <0%> (-1.52%) ⬇️
moban/jinja2/engine.py 100% <0%> (+1.19%) ⬆️
moban/core/moban_factory.py 98.02% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692086a...b710bd7. Read the comment docs.

@chfw chfw requested review from ayan-b and jayvdb September 19, 2019 22:48
@chfw
Copy link
Member Author

chfw commented Sep 21, 2019

jmfederico/jinja2-python-version#1

jina2-python-version is updated.

@chfw chfw merged commit e9d13e0 into dev Sep 25, 2019
chfw added a commit that referenced this pull request Sep 25, 2019
Release 0.6.3 - Template through Unix Pipe (#336)
@chfw chfw deleted the pipe branch October 6, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants