Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Oct 12, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

delivers #335

@codecov-io
Copy link

codecov-io commented Oct 12, 2019

Codecov Report

Merging #343 into dev will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #343      +/-   ##
==========================================
+ Coverage   95.96%   96.01%   +0.05%     
==========================================
  Files          50       51       +1     
  Lines        2625     2658      +33     
==========================================
+ Hits         2519     2552      +33     
  Misses        106      106
Impacted Files Coverage Δ
tests/test_definitions.py 100% <100%> (ø) ⬆️
tests/mobanfile/test_mobanfile.py 100% <100%> (ø) ⬆️
moban/core/definitions.py 100% <100%> (ø) ⬆️
moban/core/mobanfile/store.py 100% <100%> (ø)
tests/test_docs.py 100% <100%> (ø) ⬆️
moban/core/mobanfile/__init__.py 98.83% <100%> (+0.02%) ⬆️
moban/core/mobanfile/targets.py 98.76% <100%> (+0.03%) ⬆️
moban/core/mobanfile/templates.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7d66db...060c820. Read the comment docs.

@chfw chfw requested review from ayan-b and jayvdb October 12, 2019 15:29
@chfw chfw merged commit 8ee45b0 into dev Oct 12, 2019
@chfw chfw deleted the int-targets branch October 12, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants