Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Dec 4, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #355 into dev will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #355      +/-   ##
=========================================
+ Coverage   96.3%   96.32%   +0.02%     
=========================================
  Files         55       55              
  Lines       2812     2832      +20     
=========================================
+ Hits        2708     2728      +20     
  Misses       104      104
Impacted Files Coverage Δ
moban/constants.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f043fb7...c7380ce. Read the comment docs.

@chfw chfw merged commit 6c4ce39 into dev Dec 4, 2019
@chfw chfw deleted the demo branch December 4, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants