Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented May 21, 2020

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #381 into dev will decrease coverage by 0.02%.
The diff coverage is 94.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #381      +/-   ##
==========================================
- Coverage   96.05%   96.03%   -0.03%     
==========================================
  Files          55       56       +1     
  Lines        2868     2902      +34     
==========================================
+ Hits         2755     2787      +32     
- Misses        113      115       +2     
Impacted Files Coverage Δ
moban/core/definitions.py 100.00% <ø> (ø)
moban/core/plugins.py 100.00% <ø> (ø)
moban/externals/file_system.py 94.38% <ø> (+0.95%) ⬆️
moban/plugins/delete.py 81.81% <81.81%> (ø)
moban/constants.py 100.00% <100.00%> (ø)
moban/core/moban_factory.py 98.14% <100.00%> (+0.04%) ⬆️
moban/core/mobanfile/store.py 100.00% <100.00%> (ø)
moban/core/mobanfile/targets.py 98.79% <100.00%> (+0.02%) ⬆️
moban/core/mobanfile/templates.py 100.00% <100.00%> (ø)
moban/externals/reporter.py 96.22% <100.00%> (+0.14%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ba852...4779621. Read the comment docs.

@chfw chfw merged commit dec192f into dev May 21, 2020
@chfw chfw deleted the delete-branch branch May 24, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants