-
Notifications
You must be signed in to change notification settings - Fork 35
refactor: use pre-commit in GitHub #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
Makefile:1
- BUMP is now intended to be a required explicit input (enforced by check-bump), but NEXT_VERSION is still computed here with a silent fallback to a patch bump when BUMP is unset or invalid. This undermines the explicit requirement and can produce an unintended version if a user runs unrelated targets that expand NEXT_VERSION. Move validation before this logic (e.g. using an ifndef + $(error ...)) or defer NEXT_VERSION calculation into the bump-version recipe after check-bump passes.
DESCRIBE := $(shell git fetch --all > /dev/null && git describe --match "v*" --always --tags)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
d0d366e to
8a7ad8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This PR refactors static analysis and release tooling to consolidate Terraform formatting, validation, linting, and security scanning under pre-commit, replacing bespoke Makefile targets and simplifying the GitHub Actions workflow.
It adds a dedicated Trivy config file and updates documentation/examples and PR title validation.
versions.tfusing same pre-commit hooks as locally