Skip to content

Conversation

@moritzzimmer
Copy link
Owner

@moritzzimmer moritzzimmer commented Oct 2, 2025

This PR refactors static analysis and release tooling to consolidate Terraform formatting, validation, linting, and security scanning under pre-commit, replacing bespoke Makefile targets and simplifying the GitHub Actions workflow.

It adds a dedicated Trivy config file and updates documentation/examples and PR title validation.

  • Introduces trivy.yaml and routes Trivy settings through pre-commit
  • Replaces individual fmt/validate/tflint/trivy GitHub jobs with matrix-driven pre-commit runs for automatically detected min/max Terraform based on versions.tf using same pre-commit hooks as locally
  • desired version bump now needs to be declared explicitly

@moritzzimmer moritzzimmer changed the title refactor: use pre-commit for static checks refactor: use pre-commit in GitHub Oct 2, 2025
@moritzzimmer moritzzimmer self-assigned this Oct 2, 2025
@moritzzimmer moritzzimmer requested a review from Copilot October 2, 2025 12:30
@moritzzimmer moritzzimmer added 📖 documentation Improvements or additions to documentation 💅 enhancement New feature or request labels Oct 2, 2025

This comment was marked as outdated.

@moritzzimmer moritzzimmer requested a review from Copilot October 2, 2025 12:39
@moritzzimmer moritzzimmer marked this pull request as ready for review October 2, 2025 12:40

This comment was marked as outdated.

@moritzzimmer moritzzimmer requested a review from Copilot October 2, 2025 12:46

This comment was marked as outdated.

@moritzzimmer moritzzimmer requested a review from Copilot October 2, 2025 12:51

This comment was marked as outdated.

Copilot AI review requested due to automatic review settings October 2, 2025 12:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 2, 2025 13:05

This comment was marked as outdated.

Copilot AI review requested due to automatic review settings October 6, 2025 07:24

This comment was marked as outdated.

@moritzzimmer moritzzimmer requested a review from Copilot October 6, 2025 07:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

Makefile:1

  • BUMP is now intended to be a required explicit input (enforced by check-bump), but NEXT_VERSION is still computed here with a silent fallback to a patch bump when BUMP is unset or invalid. This undermines the explicit requirement and can produce an unintended version if a user runs unrelated targets that expand NEXT_VERSION. Move validation before this logic (e.g. using an ifndef + $(error ...)) or defer NEXT_VERSION calculation into the bump-version recipe after check-bump passes.
DESCRIBE           := $(shell git fetch --all > /dev/null && git describe --match "v*" --always --tags)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 6, 2025 07:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

This comment was marked as outdated.

@moritzzimmer moritzzimmer requested a review from Copilot October 6, 2025 08:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@moritzzimmer moritzzimmer merged commit 279fd13 into main Oct 6, 2025
3 of 5 checks passed
@moritzzimmer moritzzimmer deleted the chore/static_checks branch October 6, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📖 documentation Improvements or additions to documentation 💅 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants