Ensure initialization SQL runs only once per DuckDBDriver instance #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace HasSetMotherDuckToken with Initialized flag and mutex for thread safety - Wrap initialization logic in \!d.Initialized check to prevent duplicate execution - Update tests to use new Initialized field This prevents redundant execution of extension installation, directory setup, and MotherDuck token configuration across multiple connections. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
elefeint
approved these changes
Jun 26, 2025
| if err != nil { | ||
| return err | ||
| for _, query := range bootQueries { | ||
| // TODO: Fix context cancellation happening somewhere in the plugin. |
There was a problem hiding this comment.
todo for this PR or for future reference?
There was a problem hiding this comment.
for future reference!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
HasSetMotherDuckTokenwithInitializedflag and mutex for thread safety!d.Initializedcheck to prevent duplicate executionInitializedfieldTest plan
go test -v ./pkg/pluginto verify all tests pass🤖 Generated with Claude Code