adding a database field INFRA-606 #45
Conversation
moulid-adan
changed the title
pkg/plugin/duckdb_driver.go
Outdated
| return &ConfigError{"Path is empty"} | ||
| } | ||
| // if db has no quotes add them | ||
| if !((strings.HasPrefix(db, "'") && strings.HasSuffix(db, "'")) || (strings.HasPrefix(db, "\"") && strings.HasSuffix(db, "\""))) { |
There was a problem hiding this comment.
i think this condition should be removed.
The db path should always be escaped for single quotes. right now a user input like '/some/pa'th.ddb' will not escape the inner ' and yield an invalid attach query.
But i don't even think the outer quotes should be treated specially, as in i don't think the user should try to quote their paths at all.
There was a problem hiding this comment.
motherduck database can not, I will keep quoting if a prefix with md: has no quotes.
logger=plugin.motherduck-duckdb-datasource t=2025-09-18T16:11:23.520295756Z level=info msg="ATTACH IF NOT EXISTS md:sample_data;"
logger=plugin.motherduck-duckdb-datasource t=2025-09-18T16:11:23.521975964Z level=error msg="error querying the database: Parser Error: syntax error at or near "md""
pkg/plugin/duckdb_driver.go
Outdated
| if strings.TrimSpace(config.Path) != "" { | ||
| db := strings.TrimSpace(config.Path) | ||
| // if db has no quotes add them | ||
| if !strings.HasPrefix(db, "'") && !strings.HasSuffix(db, "'") && strings.HasPrefix(db, "md:") { | ||
| db = "'" + db + "'" | ||
| } | ||
| bootQueries = append(bootQueries, "ATTACH IF NOT EXISTS "+db+";") | ||
| backend.Logger.Info("ATTACH IF NOT EXISTS " + db + ";") | ||
| } |
There was a problem hiding this comment.
this should only be run if the db path is md:...
There was a problem hiding this comment.
when the db path is 'md:sample_data',
then duckdb.NewConnector(path, func(execer driver.ExecerContext) error { will receive path = "'md:sample_data'";
There was a problem hiding this comment.
let's keep strings.ReplaceAll(db, "'", "''")
Uh oh!
There was an error while loading. Please reload this page.