Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot state port #80

Merged
merged 13 commits into from
May 21, 2019
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented May 16, 2019

@henningkayser I have applied all the changes that you requested in a this new PR. Please close this one #59

ahcorde and others added 7 commits May 16, 2019 12:12
Co-authored-by: vmayoral <v.mayoralv@gmail.com>
Co-authored-by: anasarrak <anasarrak@gmail.com>
Co-authored-by: vmayoral <v.mayoralv@gmail.com>
Co-authored-by: anasarrak <anasarrak@gmail.com>
Co-authored-by: anasarrak <anasarrak@gmail.com>
moveit_core/robot_state/CMakeLists.txt Outdated Show resolved Hide resolved
moveit_core/robot_state/CMakeLists.txt Outdated Show resolved Hide resolved
moveit_core/robot_state/CMakeLists.txt Outdated Show resolved Hide resolved
moveit_core/robot_state/CMakeLists.txt Outdated Show resolved Hide resolved
moveit_core/robot_state/CMakeLists.txt Show resolved Hide resolved
@ahcorde
Copy link
Contributor Author

ahcorde commented May 17, 2019

@davetcoleman fixed CMakelists.txt issues

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nits. +1 from me, otherwise

moveit_core/robot_state/src/conversions.cpp Outdated Show resolved Hide resolved
#include <chrono>
#include <gtest/gtest.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are the changes in this file related to the port?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not part of the port (code-wise) but I had to modify the CMakelists.txt with ament_add_gtest. So I used this opportunity to also fix the tests.

ahcorde and others added 2 commits May 20, 2019 16:21
Co-Authored-By: Henning Kayser <henningkayser@picknik.ai>
@mlautman mlautman merged commit fa61645 into moveit:master May 21, 2019
@mlautman
Copy link
Contributor

Great!

@ahcorde ahcorde deleted the robot-state-port branch May 31, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants