Travis: Update to Noetic and fix various warnings #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
force-pushed
the
master
branch
2 times, most recently
from
dc0906c to
c371717
Compare
tylerjw
approved these changes
Oct 6, 2020
Member
tylerjw
left a comment
tylerjw
left a comment
There was a problem hiding this comment.
These changes look good. The travis issues look like they are build issues in MVT.
rhaschke
changed the title
Contributor
Author
|
No, some build issues need to be fixed here in moveit_tutorials. |
- declare missing run dependencies - find_package(rviz_visual_tools) as we declare it as a build dependency - build lerp_motion_planner_plugin directly from all sources
- unused parameters, variables - uninitialized variables - out-of-order member initialization - unsigned int vs. signed int comparison
... to have latest geometric_shapes 0.7.2 available
Contributor
|
Is this still WIP? I am currently going through the tutorials with ROS Noetic and started to update the instructions. See here. If you’d like I could rebase and open a PR on your repositories master branch to include the changes to this PR. Otherwise I could open another PR to this repository. |
rhaschke
changed the title
Contributor
Author
|
@sjahr, this is merged now. I was waiting for Travis to finally succeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.