Skip to content

Conversation

@tylerjw
Copy link
Member

@tylerjw tylerjw commented Nov 17, 2021

Description

This updates the links to the moveit2 tutorials website to be moveit.picknik.ai instead of moveit2_tutorials.picknik.ai. The reason for this change is URLs with _ in them don't get a SSL cert from github :(

@tylerjw tylerjw requested a review from auman66 November 17, 2021 23:15
Copy link
Contributor

@auman66 auman66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, I reached out to Github support and got this response:

GitHub (GitHub Support)Sep 4, 2021, 1:54 PM UTCHi
Alex,Thanks for reaching out! Lets Encrypt is not able to issue a certificate for a domain with an underscore in it, which is why moveit2_tutorials.picknik.ai isn't getting a certificate. If you can change the subdomain to something without an underscore, you should be able to get a certificate to provision.I hope this helps! Please let us know if you have further questions and we will be happy to assist.
Thanks, Tammy GitHub Support
--

@JafarAbdi JafarAbdi merged commit 93aa70d into master Nov 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the tylerjw-patch-1 branch November 22, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants