Bug 1355137 - Cache Bugzilla::Field objects that are used as visibility fields

dylanwh · dylanwh · commit be7ee16e7e7a · 2017-04-10T12:39:53.000-04:00
diff --git a/Bugzilla/Field.pm b/Bugzilla/Field.pm
@@ -640,7 +640,7 @@ sub visibility_field {
     my $self = shift;
     if ($self->{visibility_field_id}) {
         $self->{visibility_field} ||= 
-            $self->new($self->{visibility_field_id});
+            $self->new({ id => $self->{visibility_field_id}, cache => 1 });
     }
     return $self->{visibility_field};
 }

Original file line number	Diff line number	Diff line change
`@@ -640,7 +640,7 @@ sub visibility_field {`
`640`	`640`	`my $self = shift;`
`641`	`641`	`if ($self->{visibility_field_id}) {`
`642`	`642`	`$self->{visibility_field} \|\|=`
`643`		`- $self->new($self->{visibility_field_id});`
	`643`	`+ $self->new({ id => $self->{visibility_field_id}, cache => 1 });`
`644`	`644`	`}`
`645`	`645`	`return $self->{visibility_field};`
`646`	`646`	`}`