Add support for multi value params which require DQUOTEs#196
Merged
kewisch merged 2 commits intokewisch:masterfrom Jan 6, 2016
make-my-day:master
Merged
Add support for multi value params which require DQUOTEs#196kewisch merged 2 commits intokewisch:masterfrom make-my-day:master
kewisch merged 2 commits intokewisch:masterfrom
make-my-day:master
Conversation
Owner
There was a problem hiding this comment.
Does this also work if some delimiter are not found? Also, is there a chance that you can use the last found position as a starting point for the next indexOf call to save a few ops?
Owner
|
Can you squash the commits when done with the comments? You can separate out the commit for the packaged build, but it should be two commits max. |
kewisch
added a commit
that referenced
this pull request
Jan 6, 2016
Add support for multi value params which require DQUOTEs
Owner
|
Thanks for taking care! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the check in the parser for multiValueSeparateDQuote because this is within the dquoting section - in that case dquoting of the separate values is mandatory. The param getter/setter is currently used only at one place for timezones, but for consistency I added the a distinction for Array/String in/output.