Skip to content

Commit 7b1e3cd

Browse files
committed
Bug 1974444: Remove a non-standard attribute, and fix the types on some others. r=mjf,webidl,saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D255375
1 parent a93345c commit 7b1e3cd

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

dom/webidl/RTCDataChannel.webidl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,9 @@ enum RTCDataChannelType {
1717
[Exposed=Window]
1818
interface RTCDataChannel : EventTarget
1919
{
20-
readonly attribute DOMString label;
20+
readonly attribute USVString label;
2121
readonly attribute boolean negotiated;
2222
readonly attribute boolean ordered;
23-
readonly attribute boolean reliable;
2423
readonly attribute unsigned short? maxPacketLifeTime;
2524
readonly attribute unsigned short? maxRetransmits;
2625
readonly attribute USVString protocol;

dom/webidl/RTCPeerConnection.webidl

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,10 @@ dictionary RTCDataChannelInit {
6363
unsigned short maxPacketLifeTime;
6464
[EnforceRange]
6565
unsigned short maxRetransmits;
66-
DOMString protocol = "";
66+
USVString protocol = "";
6767
boolean negotiated = false;
6868
[EnforceRange]
6969
unsigned short id;
70-
71-
// These are deprecated due to renaming in the spec, but still supported for Fx53
72-
unsigned short maxRetransmitTime;
7370
};
7471

7572
dictionary RTCOfferAnswerOptions {
@@ -171,7 +168,7 @@ interface RTCPeerConnection : EventTarget {
171168

172169
readonly attribute RTCSctpTransport? sctp;
173170
// Data channel.
174-
RTCDataChannel createDataChannel (DOMString label,
171+
RTCDataChannel createDataChannel (USVString label,
175172
optional RTCDataChannelInit dataChannelDict = {});
176173
attribute EventHandler ondatachannel;
177174
};

0 commit comments

Comments
 (0)