Bug 1978487 - Make all ButtonControlFrames non-fragmentable, not just nsComboboxControlFrame. r=layout-reviewers,dshin

This matches the pre-regression behavior. I matched select's
break-inside behavior, but we might want to make that !important, since
the old code always used unconstrained bsize for the button contents?

Differential Revision: https://phabricator.services.mozilla.com/D258190

Author: emilio

layout/forms/ButtonControlFrame.cpp

@@ -43,4 +43,13 @@ nsresult ButtonControlFrame::HandleEvent(nsPresContext* aPresContext,
   return NS_OK;
 }
 
+void ButtonControlFrame::Reflow(nsPresContext* aPc, ReflowOutput& aDesiredSize,
+                                const ReflowInput& aReflowInput,
+                                nsReflowStatus& aStatus) {
+  nsBlockFrame::Reflow(aPc, aDesiredSize, aReflowInput, aStatus);
+  // We're always complete and we don't support overflow containers
+  // so we shouldn't have a next-in-flow ever.
+  aStatus.Reset();
+}
+
 }  // namespace mozilla

layout/forms/ButtonControlFrame.h

@@ -39,6 +39,9 @@ class ButtonControlFrame : public nsBlockFrame,
                        mozilla::WidgetGUIEvent* aEvent,
                        nsEventStatus* aEventStatus) override;
 
+  void Reflow(nsPresContext*, ReflowOutput&, const ReflowInput&,
+              nsReflowStatus&) override;
+
   // Given a string of text (for the button label), ensure it's not empty so
   // that line height computations work (inserting a zero-width character if
   // necessary).

layout/forms/nsComboboxControlFrame.cpp

@@ -238,9 +238,6 @@ void nsComboboxControlFrame::Reflow(nsPresContext* aPresContext,
   }
 
   ButtonControlFrame::Reflow(aPresContext, aDesiredSize, aReflowInput, aStatus);
-  // We're always complete and we don't support overflow containers
-  // so we shouldn't have a next-in-flow ever.
-  aStatus.Reset();
 }
 
 void nsComboboxControlFrame::Init(nsIContent* aContent,

layout/style/res/forms.css

@@ -228,7 +228,7 @@ select {
   overflow: clip;
   /* No text-decoration reaching inside, by default */
   display: inline-block;
-  page-break-inside: avoid;
+  break-inside: avoid;
   overflow-clip-box: padding-box !important; /* bug 992447 */
   padding-block: 1px;
 
@@ -501,6 +501,7 @@ input:is([type="color"], [type="reset"], [type="button"], [type="submit"]) {
   box-sizing: border-box;
   user-select: none;
   overflow-clip-box: padding-box;
+  break-inside: avoid;
 }
 
 /* Text-related properties for buttons: these ones are not shared with

testing/web-platform/tests/html/rendering/widgets/button-layout/input-fragmentation-crash.html

@@ -0,0 +1,11 @@
+<style>
+.parent {
+  columns: 2;
+}
+input {
+  float: inline-start;
+}
+</style>
+<div class="parent">
+  <input style="display: block" type="color">
+</div>