Skip to content

Commit df2fae2

Browse files
committed
Bug 1991998 - Add telemetry to snackbar and undo button for removing a bookmark [part 2] r=android-reviewers,skhan
Differential Revision: https://phabricator.services.mozilla.com/D267098
1 parent b45546e commit df2fae2

File tree

2 files changed

+39
-1
lines changed

2 files changed

+39
-1
lines changed

mobile/android/fenix/app/metrics.yaml

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4853,6 +4853,38 @@ bookmarks_management:
48534853
metadata:
48544854
tags:
48554855
- Bookmarks
4856+
delete_snackbar_shown:
4857+
type: event
4858+
description: |
4859+
A delete snackbar was shown after a single bookmark deletion.
4860+
bugs:
4861+
- https://bugzilla.mozilla.org/show_bug.cgi?id=1991998
4862+
data_reviews:
4863+
- https://phabricator.services.mozilla.com/D267098
4864+
data_sensitivity:
4865+
- interaction
4866+
notification_emails:
4867+
- android-probes@mozilla.com
4868+
expires: never
4869+
metadata:
4870+
tags:
4871+
- Bookmarks
4872+
delete_snackbar_undo_clicked:
4873+
type: event
4874+
description: |
4875+
The user clicked the undo button in a bookmarks delete snackbar.
4876+
bugs:
4877+
- https://bugzilla.mozilla.org/show_bug.cgi?id=1991998
4878+
data_reviews:
4879+
- https://phabricator.services.mozilla.com/D267098
4880+
data_sensitivity:
4881+
- interaction
4882+
notification_emails:
4883+
- android-probes@mozilla.com
4884+
expires: never
4885+
metadata:
4886+
tags:
4887+
- Bookmarks
48564888

48574889
activation:
48584890
identifier:

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksScreen.kt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,8 @@ import mozilla.components.concept.base.profiler.Profiler
114114
import mozilla.components.lib.state.ext.observeAsComposableState
115115
import mozilla.components.lib.state.ext.observeAsState
116116
import mozilla.components.support.ktx.android.view.hideKeyboard
117+
import mozilla.telemetry.glean.private.NoExtras
118+
import org.mozilla.fenix.GleanMetrics.BookmarksManagement
117119
import org.mozilla.fenix.R
118120
import org.mozilla.fenix.bookmarks.BookmarksTestTag.BOOKMARK_TOOLBAR
119121
import org.mozilla.fenix.bookmarks.BookmarksTestTag.EDIT_BOOKMARK_ITEM_TITLE_TEXT_FIELD
@@ -277,10 +279,14 @@ private fun BookmarksList(
277279
when (state.bookmarksSnackbarState) {
278280
BookmarksSnackbarState.None -> return@LaunchedEffect
279281
is BookmarksSnackbarState.UndoDeletion -> scope.launch {
282+
BookmarksManagement.deleteSnackbarShown.record(NoExtras())
280283
snackbarHostState.displaySnackbar(
281284
message = snackbarMessage,
282285
actionLabel = snackbarActionLabel,
283-
onActionPerformed = { store.dispatch(SnackbarAction.Undo) },
286+
onActionPerformed = {
287+
store.dispatch(SnackbarAction.Undo)
288+
BookmarksManagement.deleteSnackbarUndoClicked.record(NoExtras())
289+
},
284290
onDismissPerformed = { store.dispatch(SnackbarAction.Dismissed) },
285291
)
286292
}

0 commit comments

Comments
 (0)