This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Description
In the main code path, a NestedWebView is created for each SystemEngineSession via its WebView variable:
|
@Volatile var webView: WebView = NestedWebView(context) |
This is passed from the session to the engineView in SystemEngineView.render:
|
addView(initWebView(session.webView)) |
However, sometimes this can be null apparently – NestedWebView can also created as a default argument in SystemEngineView.initWebView:
|
internal fun initWebView(webView: WebView = NestedWebView(context)): WebView { |
There are two problems here:
- There are no comments explaining why
initWebView's default argument would need to be used (e.g. I don't know why)
- The
NestedWebView construction call is duplicated in two places (though init is shared)
I'm more concerned about the lack of comments than the duplicated constructor because the init is shared.
┆Issue is synchronized with this Jira Task